chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java - Issue 2439763002: [Android NTP] Move getDismissSiblingPosDelta into the TreeNode interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2439763002: [Android NTP] Move getDismissSiblingPosDelta into the TreeNode interface. (Closed)

Patch Set: review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

index 8a2d3d1885b908aa7a732fce3a061f6e04fa5af6..eafab2d4f6ccf664ba95561fc2b512d3de3ec3c7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

@@ -92,6 +92,12 @@ public class SignInPromo extends ChildNode implements StatusCardViewHolder.DataS

}

@Override

+ public int getDismissSiblingPosDelta(int position) {

+ checkIndex(position);

+ return 0;

+ }

+ @Override

@StringRes

public int getHeader() {

return R.string.snippets_disabled_generic_prompt;