Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: runtime/bin/eventhandler.cc

Issue 243973002: - Add a minimal implementation of Capability. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/io_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler.cc
===================================================================
--- runtime/bin/eventhandler.cc (revision 35287)
+++ runtime/bin/eventhandler.cc (working copy)
@@ -92,15 +92,11 @@
} else {
id = Socket::GetSocketIdNativeField(sender);
}
- // Get the _id field out of the port.
+ // Get the id out of the receive port. If the handle is not a receive port
+ // we will get an error and propagate that out.
Dart_Handle handle = Dart_GetNativeArgument(args, 1);
- handle = Dart_GetField(handle, DartUtils::NewString(DartUtils::kIdFieldName));
- if (Dart_IsError(handle)) {
- Dart_PropagateError(handle);
- UNREACHABLE();
- }
Dart_Port dart_port;
- handle = Dart_IntegerToInt64(handle, &dart_port);
+ handle = Dart_ReceivePortGetId(handle, &dart_port);
if (Dart_IsError(handle)) {
Dart_PropagateError(handle);
UNREACHABLE();
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/io_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698