MacViews: Use bullets for displaying obscured text.

ui/gfx/render_text.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_RENDER_TEXT_H_
 #define UI_GFX_RENDER_TEXT_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 193 matching lines @@
 }  // namespace internal
 
 // RenderText represents an abstract model of styled text and its corresponding
 // visual layout. Support is built in for a cursor, a selection, simple styling,
 // complex scripts, and bi-directional text. Implementations provide mechanisms
 // for rendering and translation between logical and visual data.
 class GFX_EXPORT RenderText {
  public:
   virtual ~RenderText();
 
+  // The character used for displaying obscured text.
+  static const base::char16 kPasswordReplacementChar;

[sky, 2016/10/24 16:13:25]

Style const says constants before destructor. Also, use constexpr.

[karandeepb, 2016/10/25 03:31:03]

Done. I initially preferred using a static const since static constexpr requires
initializing the variable along with the declaration.

+
   // Creates a platform-specific or cross-platform RenderText instance.
   static RenderText* CreateInstance();
   static RenderText* CreateInstanceForEditing();
 
   // Creates another instance of the same concrete class.
   virtual std::unique_ptr<RenderText> CreateInstanceOfSameType() const = 0;
 
   // Like above but copies all style settings too.
   std::unique_ptr<RenderText> CreateInstanceOfSameStyle(
       const base::string16& text) const;
@@ skipping 618 matching lines @@
   // Lines computed by EnsureLayout. These should be invalidated upon
   // OnLayoutTextAttributeChanged and OnDisplayTextAttributeChanged calls.
   std::vector<internal::Line> lines_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderText);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RENDER_TEXT_H_