Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2439673002: [Fetch API] Streaming error should be reported as a TypeError (Closed)

Created:
4 years, 2 months ago by yhirano
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch API] Streaming error should be reported as a TypeError When the browser encounters an error while reading a response body, it should error the body stream with a TypeError. BUG=656601 Committed: https://crrev.com/0856679f482230c36c3e1261247f30a0dcfa916e Cr-Commit-Position: refs/heads/master@{#427052}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
yhirano
4 years, 2 months ago (2016-10-20 06:42:21 UTC) #8
tyoshino (SeeGerritForStatus)
lg but the BUG number is wrong?
4 years, 2 months ago (2016-10-20 14:43:22 UTC) #11
yhirano
On 2016/10/20 14:43:22, tyoshino wrote: > lg but the BUG number is wrong? Thanks, fixed.
4 years, 2 months ago (2016-10-20 15:02:06 UTC) #13
tyoshino (SeeGerritForStatus)
lgtm
4 years, 1 month ago (2016-10-24 07:55:18 UTC) #14
haraken
LGTM
4 years, 1 month ago (2016-10-24 07:56:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439673002/40001
4 years, 1 month ago (2016-10-24 08:22:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301221)
4 years, 1 month ago (2016-10-24 10:30:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439673002/40001
4 years, 1 month ago (2016-10-24 10:32:14 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-24 12:28:14 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 12:30:43 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0856679f482230c36c3e1261247f30a0dcfa916e
Cr-Commit-Position: refs/heads/master@{#427052}

Powered by Google App Engine
This is Rietveld 408576698