Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2439653002: Fix generateAtUseSite for complex HIs checks (Closed)

Created:
4 years, 2 months ago by sra1
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix generateAtUseSite for complex HIs checks This avoids a few unnecessary temporaries. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/29ad2c2326fdb80daf473470cee2a55bf6aad11c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
4 years, 1 month ago (2016-11-16 18:52:48 UTC) #4
Siggi Cherem (dart-lang)
lgtm
4 years, 1 month ago (2016-11-16 18:54:26 UTC) #5
sra1
4 years, 1 month ago (2016-11-16 20:25:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
29ad2c2326fdb80daf473470cee2a55bf6aad11c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698