Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2439603003: Add a version number to the pubspec. (Closed)

Created:
4 years, 2 months ago by asgerf
Modified:
4 years, 2 months ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More changes to make pubspec publishable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M pubspec.yaml View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
asgerf
4 years, 2 months ago (2016-10-20 11:21:26 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years, 2 months ago (2016-10-20 11:36:40 UTC) #3
asgerf
PTAL a few more changes were needed to make the pubspec publishable
4 years, 2 months ago (2016-10-20 11:58:28 UTC) #4
Kevin Millikin (Google)
Yes, still LGTM.
4 years, 2 months ago (2016-10-20 12:01:31 UTC) #5
asgerf
4 years, 2 months ago (2016-10-20 12:02:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a8ad578344f575d45ba47f6aa2414f42d272e6f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698