Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2439593003: Add check for constness in constructor redirection (Closed)

Created:
4 years, 2 months ago by hausner
Modified:
4 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, yjbanov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add check for constness in constructor redirection Const constructor can only redirect to another const constructor. BUG=#27617 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/f73ea62c999f4ad1f4f42832e0fa97a37ed49235

Patch Set 1 #

Patch Set 2 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M runtime/vm/parser.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/regress_27617_test.dart View 1 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hausner
4 years, 2 months ago (2016-10-19 21:01:54 UTC) #3
regis
LGTM, but how about a regression test?
4 years, 2 months ago (2016-10-19 21:11:31 UTC) #4
hausner
Added test.
4 years, 2 months ago (2016-10-19 22:06:56 UTC) #5
regis
LGTM
4 years, 2 months ago (2016-10-19 22:09:19 UTC) #6
hausner
4 years, 2 months ago (2016-10-19 22:15:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f73ea62c999f4ad1f4f42832e0fa97a37ed49235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698