Issue 2439583003: Validate local resolution scope, and compute initial name scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2439583003: Validate local resolution scope, and compute initial name scope. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Validate local resolution scope, and compute initial name scope. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bf43e4b43e41f6ee898107dee8b23d5a867c86a2

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+265 lines, -31 lines)			Patch
M	pkg/analyzer/lib/src/generated/resolver.dart	View	3 chunks	+44 lines, -5 lines	1 comment	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	4 chunks	+204 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2439583003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2439583003/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode9451 pkg/analyzer/lib/src/generated/resolver.dart:9451: * Is `true` is we are in [TypeResolverMode.local] ...

4 years, 2 months ago (2016-10-19 21:00:37 UTC) #2

scheglov

4 years, 2 months ago (2016-10-19 21:08:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf43e4b43e41f6ee898107dee8b23d5a867c86a2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages