Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2439543003: Do not use overlays when VR shell is enabled. (Closed)
Patch Set: address final comments (and a rebase) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index fbc72bd25887d237f44115538543daf3d6d7e624..0499c9876277f882f8cd10472311e28889ce7594 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -250,9 +250,6 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
force_video_overlays_ = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kForceVideoOverlays);
- disable_fullscreen_video_overlays_ =
- !base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo);
-
if (delegate_)
delegate_id_ = delegate_->AddObserver(this);
@@ -312,6 +309,10 @@ void WebMediaPlayerImpl::load(LoadType load_type,
DoLoad(load_type, url, cors_mode);
}
+void WebMediaPlayerImpl::SetEnableFullscreenOverlays(bool enable_overlays) {
+ enable_fullscreen_video_overlays_ = enable_overlays;
+}
+
bool WebMediaPlayerImpl::supportsOverlayFullscreenVideo() {
#if defined(OS_ANDROID)
return true;
@@ -345,14 +346,14 @@ void WebMediaPlayerImpl::DisableOverlay() {
}
void WebMediaPlayerImpl::enteredFullscreen() {
- if (!force_video_overlays_ && !disable_fullscreen_video_overlays_)
+ if (!force_video_overlays_ && enable_fullscreen_video_overlays_)
EnableOverlay();
if (observer_)
observer_->OnEnteredFullscreen();
}
void WebMediaPlayerImpl::exitedFullscreen() {
- if (!force_video_overlays_ && !disable_fullscreen_video_overlays_)
+ if (!force_video_overlays_ && enable_fullscreen_video_overlays_)
DisableOverlay();
if (observer_)
observer_->OnExitedFullscreen();
« no previous file with comments | « media/blink/webmediaplayer_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698