Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2439543003: Do not use overlays when VR shell is enabled. (Closed)
Patch Set: Address ddorwin comments, move new methods out of ANDROID build check so they compile on all platfo… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 020adcea097348c4a25ddcf5e7fe15aac47540d1..e25fde009f94d17a24ad896a3fc0ecb3a0a3f209 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -178,6 +178,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
blink::WebContentDecryptionModule* cdm,
blink::WebContentDecryptionModuleResult result) override;
+ void SetEnableFullscreenOverlays(bool enable_overlays);
bool supportsOverlayFullscreenVideo() override;
void enteredFullscreen() override;
void exitedFullscreen() override;
@@ -532,12 +533,15 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
// cleared by the decoder.
SurfaceCreatedCB set_surface_cb_;
- // Force to use SurfaceView instead of SurfaceTexture on Android.
+ // On Android an overlay surface means using
+ // SurfaceView instead of SurfaceTexture.
+
+ // Force using video overlays for all uses of WMPI.
ddorwin 2016/12/16 19:15:18 nit: WMPI is the class, so "this class" might be b
amp 2016/12/16 19:25:03 Done.
bool force_video_overlays_;
- // Prevent use of SurfaceView on Android. (Ignored when
- // |force_video_overlays_| is true.)
- bool disable_fullscreen_video_overlays_;
+ // Use overlays for fullscreen video.
+ // (Implied if |force_video_overlays_| is true.)
+ bool enable_fullscreen_video_overlays_;
// Suppresses calls to OnPipelineError() after destruction / shutdown has been
// started; prevents us from spuriously logging errors that are transient or

Powered by Google App Engine
This is Rietveld 408576698