Do not use overlays when VR shell is enabled.

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 5007f28f5c19f40d05bae2cdb26a00a3940ca5de..0044277a936d15fecd1fde59b9fb7ffed34667b1 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2860,6 +2860,11 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
       GetWebMediaPlayerDelegate()->AsWeakPtr(),
       std::move(media_renderer_factory), url_index_, params);
 
+  // TODO(crbug/673886): Enable overlays in VR shell after video reprojection

[ddorwin, 2016/12/13 22:54:49]

s/in/when ... is enabled/.

This affects all videos, regardless of whether we are in VR shell.

[amp, 2016/12/13 23:40:01]

Done.
Yes it does and so is less desirable, but easier to implement.

+  // surface is supported.

[ddorwin, 2016/12/13 22:54:49]

Also update the CL description.

[amp, 2016/12/13 23:40:01]

Done.

+  media_player->SetDisableFullscreenOverlays(

[liberato (no reviews please), 2016/12/13 23:03:29]

this will override entirely what's in the constructor.  probably something more
like this:

if (IsEnabled)
  wmpi->DisableFullscreenOverlays();
  // or
  wmpi->SetAllowFullscreenOverlays(false);

[amp, 2016/12/13 23:40:01]

Should we pull out the media flag check currently in the WMPI constructor?

+      base::FeatureList::IsEnabled(features::kVrShell));

[mthiesse, 2016/12/13 23:03:08]

You're disabling FullscreenOverlays when VrShell is enabled at all? Why not only
when currently in VrShell?

[amp, 2016/12/13 23:40:01]

Detecting when we are in vr shell was getting messy any of the various ways I
tried to do it.

The proper thing to do seems to be to not worry about any of this and just
properly support the gvr surface reprojection.

This fix is just a stop gap until that is implemented so that full screen video
can work at all in vr.

+
 #if defined(OS_ANDROID)  // WMPI_CAST
   media_player->SetMediaPlayerManager(GetMediaPlayerManager());
   media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());