chrome/browser/ntp_snippets/fake_download_item.cc - Issue 2439533002: Download Feedback Service should upload all eligible downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ntp_snippets/fake_download_item.cc

Issue 2439533002: Download Feedback Service should upload all eligible downloads (Closed)

Patch Set: address/acknowledge comments from asanka@ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ntp_snippets/fake_download_item.cc

diff --git a/chrome/browser/ntp_snippets/fake_download_item.cc b/chrome/browser/ntp_snippets/fake_download_item.cc

index e5ea5f5c5c2ab66faed62dd1a8ae1041a282d81c..4881b1ca1b131152aa035b3e4cea14a0ad41dade 100644

--- a/chrome/browser/ntp_snippets/fake_download_item.cc

+++ b/chrome/browser/ntp_snippets/fake_download_item.cc

@@ -123,7 +123,7 @@ void FakeDownloadItem::ValidateDangerousDownload() {

}

void FakeDownloadItem::StealDangerousDownload(

- const AcquireFileCallback& callback) {

+ bool delete_file_afterward, const AcquireFileCallback& callback) {

NOTREACHED();

callback.Run(base::FilePath());

}