Download Feedback Service should upload all eligible downloads

chrome/browser/ui/views/download/download_shelf_context_menu_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_shelf_context_menu_view.h"
 
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/page_navigator.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/views/controls/menu/menu_runner.h"
 
 DownloadShelfContextMenuView::DownloadShelfContextMenuView(
-    content::DownloadItem* download_item)
-    : DownloadShelfContextMenu(download_item) {
-}
+    DownloadItemView* download_item_view)
+    : DownloadShelfContextMenu(download_item_view->download()),
+      download_item_view_(download_item_view) {}
 
 DownloadShelfContextMenuView::~DownloadShelfContextMenuView() {}
 
 void DownloadShelfContextMenuView::Run(
     views::Widget* parent_widget,
     const gfx::Rect& rect,
     ui::MenuSourceType source_type,
     const base::Closure& on_menu_closed_callback) {
   ui::MenuModel* menu_model = GetMenuModel();
   // Run() should not be getting called if the DownloadItem was destroyed.
@@ skipping 19 matching lines @@
 void DownloadShelfContextMenuView::OnMenuClosed(
     const base::Closure& on_menu_closed_callback) {
   close_time_ = base::TimeTicks::Now();
 
   // This must be run before clearing |menu_runner_| who owns the reference.
   if (!on_menu_closed_callback.is_null())
     on_menu_closed_callback.Run();
 
   menu_runner_.reset();
 }
+
+void DownloadShelfContextMenuView::ExecuteCommand(int command_id,
+                                                  int event_flags) {
+  if (static_cast<DownloadCommands::Command>(command_id) ==
+      DownloadCommands::KEEP) {
+    if (download_item_view_->ShouldAllowDownloadFeedback())

[Peter Kasting, 2016/10/24 21:39:07]

Nit: Can combine this if with the outer one

[Jialiu Lin, 2016/10/25 21:07:10]

Done.

+      download_item_view_->MaybeSubmitDownloadToFeedbackService(
+          DownloadCommands::KEEP);
+  }
+  DownloadShelfContextMenu::ExecuteCommand(command_id, event_flags);
+}