Download Feedback Service should upload all eligible downloads

content/public/browser/download_item.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Each download is represented by a DownloadItem, and all DownloadItems
 // are owned by the DownloadManager which maintains a global list of all
 // downloads. DownloadItems are created when a user initiates a download,
 // and exist for the duration of the browser life time.
 //
 // Download observers:
@@ skipping 97 matching lines @@
 
   virtual void AddObserver(DownloadItem::Observer* observer) = 0;
   virtual void RemoveObserver(DownloadItem::Observer* observer) = 0;
   virtual void UpdateObservers() = 0;
 
   // User Actions --------------------------------------------------------------
 
   // Called when the user has validated the download of a dangerous file.
   virtual void ValidateDangerousDownload() = 0;
 
-  // Called to acquire a dangerous download and remove the DownloadItem from
-  // views and history. |callback| will be invoked on the UI thread with the
-  // path to the downloaded file. The caller is responsible for cleanup.
+  // Called to acquire a dangerous download. If |delete_file_afterward| is true,
+  // |callback| will be invoked on the UI thread with the path to the downloaded
+  // file, and the DownloadItem will be removed from views and history if
+  // appropriate. Otherwise, make a temp copy of the download file, and invoke
+  // |callback| with the path to the temp copy. The caller is responsible for
+  // cleanup.

[asanka, 2016/11/07 16:01:55]

Nit: I suggest changing 'X will be <verb>d' to '<verb>s X' and '<verb> X' to
also be '<verb>s X'.

[Jialiu Lin, 2016/11/14 20:57:39]

Done.

   // Note: It is important for |callback| to be valid since the downloaded file
   // will not be cleaned up if the callback fails.
-  virtual void StealDangerousDownload(const AcquireFileCallback& callback) = 0;
+  virtual void StealDangerousDownload(bool delete_file_afterward,
+                                      const AcquireFileCallback& callback) = 0;
 
   // Pause a download.  Will have no effect if the download is already
   // paused.
   virtual void Pause() = 0;
 
   // Resume a download that has been paused or interrupted. Will have no effect
   // if the download is neither. Only does something if CanResume() returns
   // true.
   virtual void Resume() = 0;
 
@@ skipping 271 matching lines @@
   // return |name|. Has no effect on the final target filename.
   virtual void SetDisplayName(const base::FilePath& name) = 0;
 
   // Debug/testing -------------------------------------------------------------
   virtual std::string DebugString(bool verbose) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_ITEM_H_