Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: components/infobars/core/infobar_manager.h

Issue 243953002: Update PasswordManagerBrowserTest to use the new Observer class from InfoBarManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: include infobar_manager.h it is now in components/infobars/ Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/infobars/core/infobar_manager.h
diff --git a/components/infobars/core/infobar_manager.h b/components/infobars/core/infobar_manager.h
index 747d5acb79be1893a33ed3503bc0c5fa068dc5e6..b0affea19346a820e94749a4d655b77608fa63d1 100644
--- a/components/infobars/core/infobar_manager.h
+++ b/components/infobars/core/infobar_manager.h
@@ -26,11 +26,11 @@ class InfoBarManager {
// Observer class for infobar events.
class Observer {
public:
- virtual void OnInfoBarAdded(InfoBar* infobar) = 0;
- virtual void OnInfoBarRemoved(InfoBar* infobar, bool animate) = 0;
+ virtual void OnInfoBarAdded(InfoBar* infobar) {}
+ virtual void OnInfoBarRemoved(InfoBar* infobar, bool animate) {}
virtual void OnInfoBarReplaced(InfoBar* old_infobar,
- InfoBar* new_infobar) = 0;
- virtual void OnManagerShuttingDown(InfoBarManager* manager) = 0;
+ InfoBar* new_infobar) {}
+ virtual void OnManagerShuttingDown(InfoBarManager* manager) {}
Peter Kasting 2014/04/21 20:34:06 Nit: We shouldn't define virtual functions inline.
tfarina 2014/04/21 20:56:40 Done.
};
InfoBarManager();

Powered by Google App Engine
This is Rietveld 408576698