chrome/browser/infobars/infobar_manager.h - Issue 243953002: Update PasswordManagerBrowserTest to use the new Observer class from InfoBarManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/infobars/infobar_manager.h

Issue 243953002: Update PasswordManagerBrowserTest to use the new Observer class from InfoBarManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | chrome/browser/password_manager/password_manager_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/infobars/infobar_manager.h

diff --git a/chrome/browser/infobars/infobar_manager.h b/chrome/browser/infobars/infobar_manager.h

index f11768c59ae361ba20f6d35b56c36811097715bf..3b5b37947bb16963af1f5208dc1c208f42acd3c7 100644

--- a/chrome/browser/infobars/infobar_manager.h

+++ b/chrome/browser/infobars/infobar_manager.h

@@ -24,11 +24,13 @@ class InfoBarManager {

// Observer class for infobar events.

class Observer {

public:

- virtual void OnInfoBarAdded(InfoBar* infobar) = 0;

- virtual void OnInfoBarRemoved(InfoBar* infobar, bool animate) = 0;

+ virtual ~Observer() {}

Ilya Sherman 2014/04/19 19:46:04 nit: I don't think you need to explicitly define t

tfarina 2014/04/19 22:03:23 Done.

+ virtual void OnInfoBarAdded(InfoBar* infobar) {}

+ virtual void OnInfoBarRemoved(InfoBar* infobar, bool animate) {}

virtual void OnInfoBarReplaced(InfoBar* old_infobar,

- InfoBar* new_infobar) = 0;

- virtual void OnManagerShuttingDown(InfoBarManager* manager) = 0;

+ InfoBar* new_infobar) {}

+ virtual void OnManagerShuttingDown(InfoBarManager* manager) {}

};

InfoBarManager();