content/browser/android/web_contents_observer_proxy.h - Issue 2439483003: Link MediaSessionTabHelper with native MediaSession [CL is going to be split]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_proxy.h

Issue 2439483003: Link MediaSessionTabHelper with native MediaSession [CL is going to be split] (Closed)

Patch Set: Super rough, please give some initial feedbacks Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/web_contents_observer_proxy.h

diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h

index 0829acca7a48bdcd2861f41b6c83d46f8441bdc2..f74fcfe227fb3e26376075d58d5fe0491b8915e4 100644

--- a/content/browser/android/web_contents_observer_proxy.h

+++ b/content/browser/android/web_contents_observer_proxy.h

@@ -72,10 +72,6 @@ class WebContentsObserverProxy : public WebContentsObserver {

void DidStartNavigationToPendingEntry(

const GURL& url,

ReloadType reload_type) override;

- void MediaSessionStateChanged(bool is_controllable,

- bool is_suspended) override;

- void MediaSessionMetadataChanged(

- const base::Optional<MediaMetadata>& metadata) override;

void SetToBaseURLForDataURLIfNeeded(std::string* url);

void DidFailLoadInternal(bool is_provisional_load,