Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: content/public/android/java/src/org/chromium/content_public/browser/MediaSessionDelegate.java

Issue 2439483003: Link MediaSessionTabHelper with native MediaSession [CL is going to be split] (Closed)
Patch Set: Super rough, please give some initial feedbacks Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.content_public.browser;
6
7 import org.chromium.content_public.common.MediaMetadata;
8 import org.chromium.base.annotations.CalledByNative;
9 import org.chromium.base.annotations.JNINamespace;
10
11 @JNINamespace("content")
12 public class MediaSessionDelegate {
13
14 private long mNativeMediaSessionDelegateAndroid;
15
16 public boolean hasNativeMediaSession() {
boliu 2016/10/19 20:39:40 private?
Zhiqiang Zhang (Slow) 2016/10/20 16:22:32 Done.
17 return mNativeMediaSessionDelegateAndroid != 0;
18 }
19
20 public void unlinkMediaSession() {
21 if (hasNativeMediaSession())
boliu 2016/10/19 20:39:40 nit: need braces
Zhiqiang Zhang (Slow) 2016/10/20 16:22:32 Done.
22 nativeUnlinkMediaSession(mNativeMediaSessionDelegateAndroid);
23 }
24
25 @CalledByNative
26 private void mediaSessionConnected(long nativeMediaSessionDelegateAndroid) {
27 mNativeMediaSessionDelegateAndroid = nativeMediaSessionDelegateAndroid;
28 }
29
30 @CalledByNative
31 public void mediaSessionDisconnected() {
32 mNativeMediaSessionDelegateAndroid = 0;
33 }
34
35 @CalledByNative
36 public void mediaSessionStateChanged(boolean isControllable, boolean isSuspe nded) {}
37
38 @CalledByNative
39 public void mediaSessionMetadataChanged(MediaMetadata metadata) {}
40
41 public void resumeMediaSession() {}
boliu 2016/10/19 20:39:40 are these supposed to call into native?
Zhiqiang Zhang (Slow) 2016/10/20 16:22:32 Yes. Added javadoc.
42 public void suspendMediaSession() {}
43 public void stopMediaSession() {}
44
45 private native void nativeResumeMediaSession(long nativeMediaSessionDelegate Android);
46 private native void nativeSuspendMediaSession(long nativeMediaSessionDelegat eAndroid);
47 private native void nativeStopMediaSession(long nativeMediaSessionDelegateAn droid);
48 private native void nativeUnlinkMediaSession(long nativeMediaSessionDelegate Android);
49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698