Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2439453004: Revert of Accessibility: Ignore all anonymous blocks (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of https://codereview.chromium.org/2387533003/ ) Reason for revert: crbug.com/658045 Original issue's description: > Accessibility: Ignore all anonymous blocks > > Anonymous blocks are an implementation detail of the > Blink layout tree. They're surprising and not useful in > the accessibility tree. Get rid of them by marking them > all as ignored. > > While it may seem counterintuitive, this is actually > part of a longer-term plan to get rid of the idea of > ignoring nodes for accessibility, this will bring us > closer to just exposing the DOM tree plus generated > content, like FIrefox and IE do. > > The code change here is tiny, most of the change is > rebasing or updating dozens and dozens of affected > tests. I deleted a couple of tests that specifically > tested corner cases involving anonymous blocks; > the whole point of this change is to not make this a > special case anymore. > > Also updates this script, designed to automatically > pull test output from try servers to a local change: > > tools/accessibility/rebase_dump_accessibility_tree_test.py > > BUG=651614 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=aboxhall@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651614, 658045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -318 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/find.js View 4 chunks +19 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/location.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js View 2 chunks +14 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_ipc_error_browsertest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/accessibility/android_granularity_movement_browsertest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M content/renderer/accessibility/render_accessibility_impl_browsertest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-current-expected-win.txt View 1 chunk +9 lines, -7 lines 0 comments Download
M content/test/data/accessibility/aria/aria-describedby-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-describedby-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-describedby-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-labelledby-heading-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-owns-expected-mac.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-posinset-expected-android.txt View 1 chunk +16 lines, -10 lines 0 comments Download
M content/test/data/accessibility/aria/aria-posinset-expected-mac.txt View 1 chunk +18 lines, -11 lines 0 comments Download
M content/test/data/accessibility/aria/aria-posinset-expected-win.txt View 1 chunk +18 lines, -11 lines 0 comments Download
M content/test/data/accessibility/aria/aria-separator-expected-mac.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-separator-expected-win.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-mac.txt View 1 chunk +5 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-rich-text-expected-win.txt View 1 chunk +5 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-selection-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-textbox-with-selection-expected-mac.txt View 1 chunk +4 lines, -2 lines 0 comments Download
A content/test/data/accessibility/aria/aria-textbox-with-selection-expected-win.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-tooltip-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-tooltip-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-tooltip-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/a-expected-auralinux.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/a-name-calc-expected-android.txt View 1 chunk +8 lines, -7 lines 0 comments Download
M content/test/data/accessibility/html/action-verbs-expected-blink.txt View 1 chunk +14 lines, -12 lines 0 comments Download
M content/test/data/accessibility/html/button-name-calc-expected-android.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/button-name-calc-expected-mac.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/button-name-calc-expected-win.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/checkbox-name-calc-expected-android.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/checkbox-name-calc-expected-mac.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/checkbox-name-calc-expected-win.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M content/test/data/accessibility/html/cite-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/cite-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/cite-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-mac.txt View 1 chunk +10 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt View 1 chunk +8 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/element-class-id-src-attr-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/element-class-id-src-attr-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/element-class-id-src-attr-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/figcaption-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/figcaption-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/figcaption-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/iframe-cross-process-expected-blink.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-button-in-menu-expected-win.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/input-radio-expected-android.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/input-radio-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/input-radio-expected-win.txt View 1 chunk +6 lines, -3 lines 0 comments Download
M content/test/data/accessibility/html/input-text-name-calc-expected-android.txt View 1 chunk +8 lines, -7 lines 0 comments Download
M content/test/data/accessibility/html/input-text-name-calc-expected-win.txt View 1 chunk +8 lines, -7 lines 0 comments Download
M content/test/data/accessibility/html/legend-expected-android.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/legend-expected-mac.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/legend-expected-win.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-closed-expected-mac.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/modal-dialog-closed-expected-win.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/p-expected-blink.txt View 1 chunk +7 lines, -4 lines 0 comments Download
M content/test/data/accessibility/html/p-expected-mac.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/p-expected-win.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/ruby-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/ruby-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-read-only-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-read-only-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-with-selection-expected-mac.txt View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-with-selection-expected-win.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt View 3 chunks +24 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/accessibility/rebase_dump_accessibility_tree_test.py View 3 chunks +43 lines, -75 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
David Tseng
Created Revert of Accessibility: Ignore all anonymous blocks
4 years, 2 months ago (2016-10-20 22:36:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439453004/1
4 years, 2 months ago (2016-10-20 22:38:30 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 00:20:55 UTC) #6
Failed to apply patch for
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs:
While running git apply --index -3 -p1;
  <stdin>:12: trailing whitespace.
        
  <stdin>:13: trailing whitespace.
       
  <stdin>:22: trailing whitespace.
      
  error: patch failed:
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs:325
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs'
with conflicts.
  U
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
  warning: 3 lines add whitespace errors.

Patch:      
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
Index:
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
diff --git
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
index
584fd8064f4b9b8fb76800bfd535feb36242c5e0..534079fb0947c80c080cb3bdfae27530d5467624
100644
---
a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
+++
b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
@@ -260,8 +260,8 @@
           {value: undefined, index: 0}, {value: undefined, index: 5}],
   ], this.RANGE);
 });
-
-
+      
+     
 TEST_F('CursorsTest', 'LineRange', function() {
   this.runCursorMovesOnDocument(this.simpleDoc, [
         [LINE, FORWARD, {value: 'end', index: 0}, {value: 'end', index: 3}],
@@ -289,7 +289,7 @@
     cursor = cursor.move(NODE, DIRECTIONAL, BACKWARD);
     assertEquals('staticText', cursor.node.role);
     assertEquals('start diff line', cursor.node.name);
-
+    
     assertEquals('inlineTextBox', cursor.node.firstChild.role);
     assertEquals('start ', cursor.node.firstChild.name);
     assertEquals('diff ', cursor.node.firstChild.nextSibling.name);
@@ -325,7 +325,7 @@
 
 TEST_F('CursorsTest', 'SingleDocSelection', function() {
   this.runWithLoadedTree(function() {/*!
-    <p><a href="google.com">google home page</a></p>
+    <a href="google.com">google home page</a>
     <p>some more text</p>
     <p>end of text</p>
   */},

Powered by Google App Engine
This is Rietveld 408576698