Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2439443002: [NTP Client] Make the SignInPromo update on SignInAllowed changes (Closed)
Patch Set: now philosophically correct Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 8bd4ccfb61958b036c3dc2f9b902d52138bcca24..2207681a2e8b1cc67657842bbacc73ad1f21b21f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -49,6 +49,7 @@
import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager;
+import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;
import org.chromium.chrome.browser.ntp.cards.CardsVariationParameters;
import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;
@@ -57,7 +58,6 @@
import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;
import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;
-import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
import org.chromium.chrome.browser.util.MathUtils;
import org.chromium.chrome.browser.util.ViewUtils;
import org.chromium.chrome.browser.widget.RoundedIconGenerator;
@@ -297,10 +297,9 @@ void ensureIconIsAvailable(String pageUrl, String iconUrl, boolean isLargeIcon,
@Nullable SuggestionsSource getSuggestionsSource();
/**
- * Registers a {@link SignInStateObserver}, will handle the de-registration when the New Tab
- * Page goes away.
+ * Registers a {@link DestructionObserver}, notified when the New Tab Page goes away.
*/
- void registerSignInStateObserver(SignInStateObserver signInStateObserver);
+ void setDestructionObserver(DestructionObserver destructionObserver);
/**
* @return whether the {@link NewTabPage} associated with this manager is the current page

Powered by Google App Engine
This is Rietveld 408576698