[NTP Client] Make the SignInPromo update on SignInAllowed changes

chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp;
 
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.content.res.Configuration;
 import android.content.res.Resources;
@@ skipping 31 matching lines @@
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
 import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallback;
 import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
 import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
 import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
 import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager;
 import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;
+import org.chromium.chrome.browser.ntp.NewTabPage.SelfRegistrable;
 import org.chromium.chrome.browser.ntp.cards.CardsVariationParameters;
 import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;
 import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
 import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
 import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
 import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;
 import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;
-import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
 import org.chromium.chrome.browser.util.MathUtils;
 import org.chromium.chrome.browser.util.ViewUtils;
 import org.chromium.chrome.browser.widget.RoundedIconGenerator;
 import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.Set;
 
 import jp.tomorrowkey.android.gifplayer.BaseGifImage;
@@ skipping 218 matching lines @@
         void onLearnMoreClicked();
 
         /**
          * Returns the SuggestionsSource or null if it doesn't exist. The SuggestionsSource is
          * invalidated (has destroy() called) when the NewTabPage is destroyed so use this method
          * instead of keeping your own reference.
          */
         @Nullable SuggestionsSource getSuggestionsSource();
 
         /**
-         * Registers a {@link SignInStateObserver}, will handle the de-registration when the New Tab
-         * Page goes away.
+         * Registers a {@link SelfRegistrable}, will be registered right away and unregistered when
+         * when the New Tab Page goes away.
+         * TODO(dgn): This currently supports setting only one. Extend add them to a lists if

[Michael van Ouwerkerk, 2016/10/19 12:09:18]

Then maybe call it "set" instead of "add" for the moment? Then you don't need
this TODO either.

[dgn, 2016/10/19 17:03:41]

Done.

+         * needed somewhere else.

[Bernhard Bauer, 2016/10/19 12:15:27]

Yeah, I would maybe call the method set...

[dgn, 2016/10/19 17:03:41]

Done.

          */
-        void registerSignInStateObserver(SignInStateObserver signInStateObserver);
+        void addSelfRegistrable(SelfRegistrable selfRegistrable);
 
         /**
          * @return whether the {@link NewTabPage} associated with this manager is the current page
          * displayed to the user.
          */
         boolean isCurrentPage();
     }
 
     /**
      * Default constructor required for XML inflation.
@@ skipping 910 matching lines @@
     }
 
     /**
      * @return The adapter position the user has scrolled to.
      */
     public int getScrollPosition() {
         if (mUseCardsUi) return mRecyclerView.getScrollPosition();
         return RecyclerView.NO_POSITION;
     }
 }