Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2439413002: [Bindings] Remove activity_logging_world_check in v8 method template (Closed)

Created:
4 years, 1 month ago by peria
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove checking activity_logging_world_check in v8 method template. It is not defined in implementation, and it is not needed to be checked. https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md#LogActivity_m_a BUG=650150 Committed: https://crrev.com/233364e61ae1b39f6b13bc1fda73926e43048e49 Cr-Commit-Position: refs/heads/master@{#427055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
peria
PTL
4 years, 1 month ago (2016-10-24 07:43:37 UTC) #3
haraken
LGTM
4 years, 1 month ago (2016-10-24 07:51:24 UTC) #5
bashi
lgtm
4 years, 1 month ago (2016-10-24 07:54:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439413002/1
4 years, 1 month ago (2016-10-24 07:57:25 UTC) #8
Yuki
lgtm
4 years, 1 month ago (2016-10-24 08:18:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301185)
4 years, 1 month ago (2016-10-24 10:08:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439413002/1
4 years, 1 month ago (2016-10-24 12:34:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 13:23:05 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:24:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/233364e61ae1b39f6b13bc1fda73926e43048e49
Cr-Commit-Position: refs/heads/master@{#427055}

Powered by Google App Engine
This is Rietveld 408576698