Refactor BlimpConnection to TCPConnection

blimp/net/tcp_engine_transport.h

Index: blimp/net/tcp_engine_transport.h
diff --git a/blimp/net/tcp_engine_transport.h b/blimp/net/tcp_engine_transport.h
index 93f426b88e9837825d39c52b3459e9f1f9f2da1c..a2b6a8afd3594c9e77b9080293563c3ab22e1e96 100644
--- a/blimp/net/tcp_engine_transport.h
+++ b/blimp/net/tcp_engine_transport.h
@@ -24,8 +24,8 @@ namespace blimp {
 
 class MessagePort;
 
-// BlimpTransport which listens for a TCP connection at |address|.
-class BLIMP_NET_EXPORT TCPEngineTransport : public BlimpTransport {
+// |BlimpTransport| which listens for a TCP connection at |address|.
+class BLIMP_NET_EXPORT TCPEngineTransport : public BlimpEngineTransport {
  public:
   // Caller retains the ownership of |net_log|.
   TCPEngineTransport(const net::IPEndPoint& address,
@@ -34,11 +34,11 @@ class BLIMP_NET_EXPORT TCPEngineTransport : public BlimpTransport {
 
   // BlimpTransport implementation.
   void Connect(const net::CompletionCallback& callback) override;
-  std::unique_ptr<MessagePort> TakeMessagePort() override;
+  std::unique_ptr<BlimpConnection> MakeConnection() override;
   const char* GetName() const override;
+  void GetLocalAddress(net::IPEndPoint* address) const override;
 
-  int GetLocalAddress(net::IPEndPoint* address) const;
-
+  std::unique_ptr<MessagePort> TakeMessagePort();

[Garrett Casto, 2016/10/26 23:43:48]

Should this be private now? I don't see any public callers.

[perumaal, 2016/10/27 00:16:05]

Tests :( 
GrpcTransport won't have this issue hopefully.

  private:
   void OnTCPConnectAccepted(int result);