Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/client/core/session/client_network_components.cc

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Sync merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/session/assignment_source.cc ('k') | blimp/client/public/session/assignment.h » ('j') | blimp/engine/session/blimp_engine_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/session/client_network_components.cc
diff --git a/blimp/client/core/session/client_network_components.cc b/blimp/client/core/session/client_network_components.cc
index f8ce52490e48879aead78d0c7656ada5c1bf7a7b..80f7f1939e36f2e8740becb9be6be026fd0a55a2 100644
--- a/blimp/client/core/session/client_network_components.cc
+++ b/blimp/client/core/session/client_network_components.cc
@@ -47,6 +47,13 @@ void ClientNetworkComponents::ConnectWithAssignment(
assignment.engine_endpoint, nullptr));
transport_type = "TCP";
break;
+ case Assignment::GRPC:
+ // TODO(perumaal): Unimplemented as yet.
+ // connection_manager_->AddTransport(
+ // base::MakeUnique<GrpcClientTransport>(endpoint));
+ transport_type = "GRPC";
+ NOTIMPLEMENTED() << "Not yet implemented!";
Garrett Casto 2016/10/26 23:43:48 Nit: Just "NOTIMPLEMENTED();" is fine.
perumaal 2016/10/27 00:16:04 Done.
+ break;
case Assignment::UNKNOWN:
LOG(FATAL) << "Unknown transport type.";
break;
« no previous file with comments | « blimp/client/core/session/assignment_source.cc ('k') | blimp/client/public/session/assignment.h » ('j') | blimp/engine/session/blimp_engine_session.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698