Refactor BlimpConnection to TCPConnection

blimp/net/client_connection_manager.cc

Index: blimp/net/client_connection_manager.cc
diff --git a/blimp/net/client_connection_manager.cc b/blimp/net/client_connection_manager.cc
index 4218b2d512796e53e5b15e2a8b0a9bad41f075e8..df2d3b52d4a18a9095385488a9e1bfadfccfda11 100644
--- a/blimp/net/client_connection_manager.cc
+++ b/blimp/net/client_connection_manager.cc
@@ -57,9 +57,9 @@ void ClientConnectionManager::Connect(int transport_index) {
 void ClientConnectionManager::OnConnectResult(int transport_index, int result) {
   DCHECK_NE(result, net::ERR_IO_PENDING);
   const auto& transport = transports_[transport_index];
+  DVLOG(3) << "OnConnectResult; result = " << result;

[Garrett Casto, 2016/10/25 18:33:50]

Nit: Everything else in this file is DVLOG(1). If you are going to log here, I
would stick with that. VLOG(3) is normally extremely detailed logging.

[perumaal, 2016/10/25 23:02:39]

Cool, good idea. thanks

   if (result == net::OK) {
-    std::unique_ptr<BlimpConnection> connection =
-        base::MakeUnique<BlimpConnection>(transport->TakeMessagePort());
+    std::unique_ptr<BlimpConnection> connection = transport->MakeConnection();
     connection->AddConnectionErrorObserver(this);
     SendAuthenticationMessage(std::move(connection));
   } else {
@@ -80,8 +80,7 @@ void ClientConnectionManager::SendAuthenticationMessage(
 }
 
 void ClientConnectionManager::OnAuthenticationMessageSent(
-    std::unique_ptr<BlimpConnection> connection,
-    int result) {
+    std::unique_ptr<BlimpConnection> connection, int result) {
   DVLOG(1) << "AuthenticationMessageSent, result=" << result;
   if (result != net::OK) {
     // If a write error occurred, just throw away |connection|.