Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/net/tcp_client_transport.h

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Added missing Engine Transport Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/net/engine_connection_manager.cc ('K') | « blimp/net/stream_packet_reader.cc ('k') | blimp/net/tcp_client_transport.cc » ('j') | blimp/net/tcp_client_transport.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/tcp_client_transport.h
diff --git a/blimp/net/tcp_client_transport.h b/blimp/net/tcp_client_transport.h
index aa8f049ef96e67f21465d855defa5b9c170b3f27..c781118c6f5d688b5ade607cb3aa165fe49a6994 100644
--- a/blimp/net/tcp_client_transport.h
+++ b/blimp/net/tcp_client_transport.h
@@ -37,7 +37,10 @@ class BLIMP_NET_EXPORT TCPClientTransport : public BlimpTransport {
// BlimpTransport implementation.
void Connect(const net::CompletionCallback& callback) override;
- std::unique_ptr<MessagePort> TakeMessagePort() override;
+ std::unique_ptr<BlimpConnection> MakeConnection() override;
+
+ std::unique_ptr<MessagePort> TakeMessagePort();
Wez 2016/11/09 22:47:17 nit: Please add a comment to clarify why this is h
+
const char* GetName() const override;
protected:
« blimp/net/engine_connection_manager.cc ('K') | « blimp/net/stream_packet_reader.cc ('k') | blimp/net/tcp_client_transport.cc » ('j') | blimp/net/tcp_client_transport.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698