Refactor BlimpConnection to TCPConnection

blimp/net/tcp_transport_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <memory>
 #include <string>
 
 #include "base/message_loop/message_loop.h"
 #include "blimp/common/create_blimp_message.h"
@@ skipping 26 matching lines @@
         engine_(local_address_, nullptr),
         read_buffer_(new net::GrowableIOBuffer) {
     size_t buf_size = std::max(payload_1_.size(), payload_2_.size());
     write_buffer_ = make_scoped_refptr(
         new net::DrainableIOBuffer(new net::IOBuffer(buf_size), buf_size));
     read_buffer_->SetCapacity(buf_size);
   }
 
   net::IPEndPoint GetLocalEndpoint() const {
     net::IPEndPoint local_address;
-    CHECK_EQ(net::OK, engine_.GetLocalAddress(&local_address));
+    engine_.GetLocalAddress(&local_address);

[Wez, 2016/11/09 22:47:17]

Why remove the CHECK?

     return local_address;
   }
 
   std::string payload_1_ = "foo";
   std::string payload_2_ = "bar";
   base::MessageLoopForIO message_loop_;
   net::IPEndPoint local_address_;
   TCPEngineTransport engine_;
   scoped_refptr<net::DrainableIOBuffer> write_buffer_;
   scoped_refptr<net::GrowableIOBuffer> read_buffer_;
@@ skipping 68 matching lines @@
   engine_message_port->reader()->ReadPacket(read_buffer_, read_cb2.callback());
   EXPECT_EQ(payload_2_.size(), static_cast<size_t>(read_cb2.WaitForResult()));
   EXPECT_EQ(net::OK, write_cb2.WaitForResult());
   EXPECT_TRUE(
       BufferStartsWith(read_buffer_.get(), payload_2_.size(), payload_2_));
 }
 
 }  // namespace
 
 }  // namespace blimp