Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: blimp/net/blimp_transport.h

Issue 2439403003: Refactor BlimpConnection to TCPConnection (Closed)
Patch Set: Added missing Engine Transport Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_NET_BLIMP_TRANSPORT_H_ 5 #ifndef BLIMP_NET_BLIMP_TRANSPORT_H_
6 #define BLIMP_NET_BLIMP_TRANSPORT_H_ 6 #define BLIMP_NET_BLIMP_TRANSPORT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "net/base/completion_callback.h" 11 #include "net/base/completion_callback.h"
12 12
13 namespace blimp { 13 namespace blimp {
14 14
15 class BlimpConnection; 15 class BlimpConnection;
16 class MessagePort;
17 16
18 // An interface which encapsulates the transport-specific code for 17 // An interface which encapsulates the transport-specific code for
19 // establishing network connections between the client and engine. 18 // establishing network connections between the client and engine.
20 // Subclasses of BlimpTransport are responsible for defining their own 19 // Subclasses of BlimpTransport are responsible for defining their own
21 // methods for receiving connection arguments. 20 // methods for receiving connection arguments.
22 class BlimpTransport { 21 class BlimpTransport {
23 public: 22 public:
24 virtual ~BlimpTransport() {} 23 virtual ~BlimpTransport() {}
25 24
26 // Initiate or listen for a connection. 25 // Initiate or listen for a connection.
27 // 26 //
28 // |callback| is passed net::OK if a connection was successfully 27 // |callback| is passed net::OK if a connection was successfully
29 // established. The connection's MessagePort can then be taken by calling 28 // established.
30 // TakeMessagePort().
31 // All other values indicate a connection error. 29 // All other values indicate a connection error.
32 virtual void Connect(const net::CompletionCallback& callback) = 0; 30 virtual void Connect(const net::CompletionCallback& callback) = 0;
33 31
34 // Returns the MessagePort of a successfully established connection. 32 // Creates a new |BlimpConnection| for the specific |BlimpTransport|
35 virtual std::unique_ptr<MessagePort> TakeMessagePort() = 0; 33 // implementation. Must not be called until |Connect|'s callback returns
34 // net::OK.
35 virtual std::unique_ptr<BlimpConnection> MakeConnection() = 0;
36 36
37 // Gets the transport name, e.g. "TCP", "SSL", "mock", etc. 37 // Gets the transport name, e.g. "TCP", "SSL", "mock", etc.
38 virtual const char* GetName() const = 0; 38 virtual const char* GetName() const = 0;
39 }; 39 };
40 40
41 } // namespace blimp 41 } // namespace blimp
42 42
43 #endif // BLIMP_NET_BLIMP_TRANSPORT_H_ 43 #endif // BLIMP_NET_BLIMP_TRANSPORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698