Refactor BlimpConnection to TCPConnection

blimp/net/blimp_engine_transport.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_NET_BLIMP_ENGINE_TRANSPORT_H_
+#define BLIMP_NET_BLIMP_ENGINE_TRANSPORT_H_
+
+#include <memory>
+#include <string>
+
+#include "blimp/net/blimp_transport.h"
+#include "net/base/ip_endpoint.h"
+
+namespace blimp {
+
+// Interface specific to engine transport on top of generic |BlimpTransport|.
+class BlimpEngineTransport : public BlimpTransport {

[Wez, 2016/11/09 22:47:17]

The GetLocalAddress() API only makes sense for an IP-based protocol like TCP, so
can we put the API on TcpEngineTransport instead and avoid the extra interface?

Or are you intending to re-use this for GRPC?

[perumaal, 2016/11/10 02:05:05]

I am reusing this for GRPC. Please see
https://codereview.chromium.org/2462183002/diff/80001/blimp/net/blimp_engine_...

I also talked with dtrainor@ as I wanted to make the client/engine APIs be
symmetric and use the same opaque structure; this also ties in well with the
tests (unit-tests & integration tests).

+ public:
+  ~BlimpEngineTransport() override {}
+
+  // Obtains the local listening address.
+  virtual void GetLocalAddress(net::IPEndPoint* ip_address) const = 0;
+};
+
+}  // namespace blimp
+
+#endif  // BLIMP_NET_BLIMP_ENGINE_TRANSPORT_H_