Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2439393002: X87: [compiler] Mark shared functions for optimization. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Mark shared functions for optimization. port 4a31323e973e0a03403a53c601dfd4f0237532e8 (r40506) original commit message: The current method of marking functions for optimization, which replaces the JSFunction's code object with one that triggers optimization, would never allow unnamed functions to be optimized. This is an issue for a style of programming which heavily relies on passing around closures. This patch sets a bit on the SharedFunctionInfo when a JSFunction is marked. When another JSFunction referring to the same SharedFunctionInfo is lazily compiled, it immediately triggers a non-concurrent optimize. BUG= Committed: https://crrev.com/ac8318e2e03b4ddb0c7fb82a71cb37cfcc72c1fc Cr-Commit-Position: refs/heads/master@{#40520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-10-24 02:47:14 UTC) #2
Weiliang
lgtm
4 years, 1 month ago (2016-10-24 04:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439393002/1
4 years, 1 month ago (2016-10-24 06:16:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 06:42:56 UTC) #6
Leszek Swirski
Thanks for catching and fixing this.
4 years, 1 month ago (2016-10-24 14:46:31 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac8318e2e03b4ddb0c7fb82a71cb37cfcc72c1fc
Cr-Commit-Position: refs/heads/master@{#40520}

Powered by Google App Engine
This is Rietveld 408576698