recipe_modules/tryserver/example.expected/with_gerrit_patch.json - Issue 2439373002: bot_update: understand new Gerrit patch properties.

Unified Diff: recipe_modules/tryserver/example.expected/with_gerrit_patch.json

Issue 2439373002: bot_update: understand new Gerrit patch properties. (Closed)

Patch Set: Expectations. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« recipe_modules/tryserver/api.py ('K') | « recipe_modules/tryserver/example.py ('k') | recipe_modules/tryserver/example.expected/with_gerrit_patch_deprecated.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/tryserver/example.expected/with_gerrit_patch.json

diff --git a/recipe_modules/tryserver/example.expected/with_wrong_patch.json b/recipe_modules/tryserver/example.expected/with_gerrit_patch.json

similarity index 67%

copy from recipe_modules/tryserver/example.expected/with_wrong_patch.json

copy to recipe_modules/tryserver/example.expected/with_gerrit_patch.json

index 47a6d1e352119529a125c07d04d9d418f3b83d63..39cba07f364a4105b61727a113b4022e2490a07a 100644

--- a/recipe_modules/tryserver/example.expected/with_wrong_patch.json

+++ b/recipe_modules/tryserver/example.expected/with_gerrit_patch.json

@@ -1,18 +1,7 @@

[

Michael Achenbach 2016/10/24 08:18:13 Are the two expectation files useful? Not sure wha

tandrii(chromium) 2016/10/24 11:43:37 The deprecated one is to be removed once all users

Michael Achenbach 2016/10/24 11:57:49 This doesn't fully answer my question. I was compa

tandrii(chromium) 2016/10/24 12:03:54 Ah, I see now. Logically, there should be, but app

{

"cmd": [

- "python",

- "-u",

- "RECIPE_PACKAGE_REPO[depot_tools]\\bootstrap\\win\\git_bootstrap.py",

- "--verbose"

- ],

- "cwd": "RECIPE_PACKAGE_REPO[depot_tools]",

- "name": "ensure git tooling on windows",

- "timeout": 300

- },

- {

- "cmd": [

- "RECIPE_PACKAGE_REPO[depot_tools]\\git.bat",

+ "git",

"diff",

"--cached",

"--name-only"

@@ -22,7 +11,9 @@

"stdout": "/path/to/tmp/",

"~followup_annotations": [

"@@@STEP_LOG_LINE@files@foo.cc@@@",

- "@@@STEP_LOG_END@files@@@"

+ "@@@STEP_LOG_END@files@@@",

+ "@@@SET_BUILD_PROPERTY@failure_type@\"INVALID_TEST_RESULTS\"@@@",

+ "@@@SET_BUILD_PROPERTY@subproject_tag@\"v8\"@@@"

]

{