Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

Issue 2439303002: Record UMA on number of days since data reduction proxy is enabled. (Closed)
Patch Set: fix compile error Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
index cc537954c915be0380d121bea6d53a617a8b3d03..2f156375381820005794ae6f6b6dfadfb0ae611d 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
@@ -10,6 +10,8 @@
#include <string>
#include "base/message_loop/message_loop.h"
+#include "base/time/clock.h"
+#include "base/time/time.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
#include "components/prefs/testing_pref_service.h"
#include "net/log/test_net_log.h"
@@ -51,11 +53,14 @@ class DataReductionProxySettingsTestBase : public testing::Test {
void SetUp() override;
- template <class C> void ResetSettings(bool allowed,
- bool fallback_allowed,
- bool promo_allowed,
- bool holdback);
- virtual void ResetSettings(bool allowed,
+ template <class C>
+ void ResetSettings(std::unique_ptr<base::Clock> clock,
+ bool allowed,
+ bool fallback_allowed,
+ bool promo_allowed,
+ bool holdback);
+ virtual void ResetSettings(std::unique_ptr<base::Clock> clock,
+ bool allowed,
bool fallback_allowed,
bool promo_allowed,
bool holdback) = 0;
@@ -93,12 +98,13 @@ class ConcreteDataReductionProxySettingsTest
: public DataReductionProxySettingsTestBase {
public:
typedef MockDataReductionProxySettings<C> MockSettings;
- void ResetSettings(bool allowed,
+ void ResetSettings(std::unique_ptr<base::Clock> clock,
+ bool allowed,
bool fallback_allowed,
bool promo_allowed,
bool holdback) override {
return DataReductionProxySettingsTestBase::ResetSettings<C>(
- allowed, fallback_allowed, promo_allowed, holdback);
+ std::move(clock), allowed, fallback_allowed, promo_allowed, holdback);
}
};

Powered by Google App Engine
This is Rietveld 408576698