Disable ES3 on Android version < 4.4

Certain old drivers wrongly advertise ES3 context support.  Disable ES3
on all Android versions before 4.4 (KitKat).

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/72c05314e1a2883704f928dce5b240f51f23fbe2
Cr-Commit-Position: refs/heads/master@{#427232}

[vmiura, 2016-10-21 23:27:15]

Description was changed from

==========
Disable ES3 on Adreno 3xx drivers that wrongly advertise ES3 support.

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
==========

to

==========
Disable ES3 on Adreno 3xx drivers that wrongly advertise ES3 support.

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[vmiura, 2016-10-21 23:27:20]

The CQ bit was checked by vmiura@chromium.org to run a CQ dry run

[vmiura, 2016-10-21 23:27:57]

PTAL

[commit-bot: I haz the power, 2016-10-21 23:28:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-21 23:29:57]

lgtm

[aelias_OOO_until_Jul13, 2016-10-22 00:02:31]

https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_json.cc:2168: "gl_renderer": "Adreno \\(TM\\)
3.*",
Could we remove this line and just simply rely on the gl_version < 3.0 check?

[Zhenyao Mo, 2016-10-22 00:24:27]

On 2016/10/22 00:02:31, aelias wrote:
>
https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
> File gpu/config/gpu_driver_bug_list_json.cc (right):
> 
>
https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
> gpu/config/gpu_driver_bug_list_json.cc:2168: "gl_renderer": "Adreno \\(TM\\)
> 3.*",
> Could we remove this line and just simply rely on the gl_version < 3.0 check?

The shm context you mentioned for gpu info collection purpose, do we always try
to create an ES2 context?  If yes, then for drivers which honor it will never be
allowed to create ES3 context, even though the ES3 context could be totally
fine.  Is that a valid concern?

[aelias_OOO_until_Jul13, 2016-10-22 00:29:25]

On 2016/10/22 at 00:24:27, zmo wrote:
> On 2016/10/22 00:02:31, aelias wrote:
> >
https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
> > File gpu/config/gpu_driver_bug_list_json.cc (right):
> > 
> >
https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
> > gpu/config/gpu_driver_bug_list_json.cc:2168: "gl_renderer": "Adreno \\(TM\\)
> > 3.*",
> > Could we remove this line and just simply rely on the gl_version < 3.0
check?
> 
> The shm context you mentioned for gpu info collection purpose, do we always
try to create an ES2 context?  If yes, then for drivers which honor it will
never be allowed to create ES3 context, even though the ES3 context could be
totally fine.  Is that a valid concern?

I'm not sure I follow your concern.  AFAIK, "gl_version" is just based on
parsing GL_VERSION, which AFAIK is just a constant string irrespective of
context initialization mode.

[Zhenyao Mo, 2016-10-22 00:34:15]

On 2016/10/22 00:29:25, aelias wrote:
> On 2016/10/22 at 00:24:27, zmo wrote:
> > On 2016/10/22 00:02:31, aelias wrote:
> > >
>
https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
> > > File gpu/config/gpu_driver_bug_list_json.cc (right):
> > > 
> > >
>
https://codereview.chromium.org/2439253002/diff/1/gpu/config/gpu_driver_bug_l...
> > > gpu/config/gpu_driver_bug_list_json.cc:2168: "gl_renderer": "Adreno
\\(TM\\)
> > > 3.*",
> > > Could we remove this line and just simply rely on the gl_version < 3.0
> check?
> > 
> > The shm context you mentioned for gpu info collection purpose, do we always
> try to create an ES2 context?  If yes, then for drivers which honor it will
> never be allowed to create ES3 context, even though the ES3 context could be
> totally fine.  Is that a valid concern?
> 
> I'm not sure I follow your concern.  AFAIK, "gl_version" is just based on
> parsing GL_VERSION, which AFAIK is just a constant string irrespective of
> context initialization mode.

If we request GLES2 and is honored, the GL_VERSION string will be "OpenGL ES
2.0" and gl_version will be 2.0
if we request GLES3 and is honored, the GL_VERSION string will be "OpenGL ES
3.0" and gl_version will be 3.0.

[aelias_OOO_until_Jul13, 2016-10-22 00:39:25]

OK, if that's the case, then this patch already disabled OpenGL ES 3.0 for all
Adreno 3xx, then?  That's already pretty broad since that's a popular GPU that
mostly supports ES3 just fine.  If there's really no more targeted way to
distinguish, I suggest disabling ES3 on Android <4.4.

[vmiura, 2016-10-22 01:06:50]

The CQ bit was checked by vmiura@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-22 01:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmiura, 2016-10-22 01:07:37]

Disabled on Android < 4.4.  PTAL.

[vmiura, 2016-10-22 01:08:50]

Description was changed from

==========
Disable ES3 on Adreno 3xx drivers that wrongly advertise ES3 support.

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Certain old drivers wrongly advertise ES3 context support.  Disable ES3
on all Android versions before 4.4 (KitKat).

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[aelias_OOO_until_Jul13, 2016-10-22 01:15:01]

lgtm

[Zhenyao Mo, 2016-10-22 01:41:09]

On 2016/10/22 01:15:01, aelias wrote:
> lgtm

still lgtm

[commit-bot: I haz the power, 2016-10-22 03:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 03:50:36]

Dry run: This issue passed the CQ dry run.

[vmiura, 2016-10-24 22:20:46]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:21:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:51:22]

Description was changed from

==========
Certain old drivers wrongly advertise ES3 context support.  Disable ES3
on all Android versions before 4.4 (KitKat).

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Certain old drivers wrongly advertise ES3 context support.  Disable ES3
on all Android versions before 4.4 (KitKat).

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-25 01:51:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 01:54:39]

Description was changed from

==========
Certain old drivers wrongly advertise ES3 context support.  Disable ES3
on all Android versions before 4.4 (KitKat).

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Certain old drivers wrongly advertise ES3 context support.  Disable ES3
on all Android versions before 4.4 (KitKat).

R=aelias@chromium.org
R=zmo@chromium.org
BUG=657925
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/72c05314e1a2883704f928dce5b240f51f23fbe2
Cr-Commit-Position: refs/heads/master@{#427232}
==========

[commit-bot: I haz the power, 2016-10-25 01:54:40]

Patchset 2 (id:??) landed as
https://crrev.com/72c05314e1a2883704f928dce5b240f51f23fbe2
Cr-Commit-Position: refs/heads/master@{#427232}