third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html - Issue 2439223002: DevTools: Use grey hint text for applied suggestion in TextPrompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html

Issue 2439223002: DevTools: Use grey hint text for applied suggestion in TextPrompt (Closed)

Patch Set: newline for test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html

index b79f7029707304bbc04fb56988eb6756aa86d364..92312a702f3c7fb6a291c4281fe491f1c2f399f1 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html

@@ -55,6 +55,12 @@ function test()

{

completionsDone();

dumpTextPrompt();

+ prompt.setText("something_before test");

+ prompt.complete();

+ completionsDone();

+ dumpTextPrompt();

+ typeCharacter("T");

+ dumpTextPrompt();

UnitTest.completeTest();

}

@@ -90,7 +96,7 @@ function test()

var selection = element.getComponentSelection();

var range = selection.getRangeAt(0);

- var textNode = prompt._autocompleteElement ? prompt._autocompleteElement.previousSibling : element.childTextNodes()[element.childTextNodes().length-1];

+ var textNode = prompt._autocompleteElement.parentNode ? prompt._autocompleteElement.previousSibling : element.childTextNodes()[element.childTextNodes().length-1];

if (!character)

textNode.textContent = textNode.textContent.substring(0,textNode.textContent.length-1);

else