Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html

Issue 2439223002: DevTools: Use grey hint text for applied suggestion in TextPrompt (Closed)
Patch Set: Was removing ghostText twice Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html
index 6100c27aad5c97fe0e992a3b71a5be7c8d59724e..75c65df63e04e19c50bb13d84c4140c75cf4fc05 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html
@@ -56,6 +56,12 @@ function test()
{
completionsDone();
dumpTextPrompt();
+ prompt.setText("something_before test");
+ prompt.complete();
+ completionsDone();
+ dumpTextPrompt();
+ typeCharacter("T");
+ dumpTextPrompt();
UnitTest.completeTest();
}
@@ -91,7 +97,7 @@ function test()
var selection = element.getComponentSelection();
var range = selection.getRangeAt(0);
- var textNode = prompt._ghostTextElement ? prompt._ghostTextElement.previousSibling : element.childTextNodes()[element.childTextNodes().length - 1];
+ var textNode = prompt._ghostTextElement.parentNode ? prompt._ghostTextElement.previousSibling : element.childTextNodes()[element.childTextNodes().length - 1];
if (!character)
textNode.textContent = textNode.textContent.substring(0,textNode.textContent.length-1);
else
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698