Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2439213002: Add step to process Render Test results. (Closed)
Patch Set: Add step to process Render Test results. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 9b2008567e1e357194ec3885bcaefd190df0acfa..6c520e6e3cdb4e27898fb96aeef7cb3ffff62c27 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -1527,6 +1527,23 @@ class AndroidApi(recipe_api.RecipeApi):
)
return diff.stdout.splitlines()
+ def upload_render_test_failures(self, render_results_dir):
+ """Uploads render test results. Generates HTML file displaying results."""
+ args = ['--output-html-file', self.m.raw_io.output(),
+ '--buildername', self.m.properties['buildername'],
+ '--build-number', self.m.properties['buildnumber'],
+ '--render-results-dir', render_results_dir]
+ step_result = self.m.python(
+ name='[Render Tests] Upload Results',
+ script=self.m.path['checkout'].join(
+ 'build', 'android', 'render_tests',
+ 'process_render_test_results.py'),
+ args=args,
+ step_test_data=lambda: self.m.raw_io.test_api.output(
+ '<!DOCTYPE html><html></html>'))
+ step_result.presentation.logs[
jbudorick 2016/10/25 17:03:40 nit: don't break here; do something like step_r
mikecase (-- gone --) 2016/10/25 20:53:33 Done
+ 'render results'] = step_result.raw_io.output.splitlines()
+
@contextlib.contextmanager
def handle_exit_codes(self):
"""Handles exit codes emitted by the test runner and other scripts."""

Powered by Google App Engine
This is Rietveld 408576698