Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json

Issue 2439213002: Add step to process Render Test results. (Closed)
Patch Set: Addressed jbudorick's nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
diff --git a/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
index a7fb9c97ed037fdd045f9dfcfea2a5ef4de2d05c..d9032ffda46cd5d73a6a37f3555c37748225fe03 100644
--- a/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
+++ b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
@@ -227,6 +227,7 @@
"@@@STEP_LOG_LINE@json.output@ \"omg_so_many_apks\"@@@",
"@@@STEP_LOG_LINE@json.output@ ], @@@",
"@@@STEP_LOG_LINE@json.output@ \"apk_under_test\": \"second_apk\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"render_results_dir\": \"chrome/test/data/android/render_tests\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"test\": \"ChromePublicTest\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"test_apk\": \"one_apk\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
@@ -592,6 +593,18 @@
]
},
{
+ "cmd": [],
+ "env": {
+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
+ "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
+ },
+ "name": "ChromePublicTest",
+ "~followup_annotations": [
+ "@@@STEP_TEXT@<br/>failures:<br/>Test.Two<br/>@@@",
+ "@@@STEP_FAILURE@@@"
+ ]
+ },
+ {
"cmd": [
"python",
"-u",
@@ -609,8 +622,9 @@
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
},
- "name": "ChromePublicTest",
+ "name": "ChromePublicTest.ChromePublicTest",
"~followup_annotations": [
+ "@@@STEP_NEST_LEVEL@1@@@",
"step returned non-zero exit code: 1",
"@@@STEP_FAILURE@@@"
]
@@ -619,6 +633,31 @@
"cmd": [
"python",
"-u",
+ "[SLAVE_BUILD]/src/build/android/render_tests/process_render_test_results.py",
+ "--output-html-file",
+ "/path/to/tmp/",
+ "--buildername",
+ "Android Tests",
+ "--build-number",
+ "571",
+ "--render-results-dir",
+ "chrome/test/data/android/render_tests"
+ ],
+ "env": {
+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
+ "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
+ },
+ "name": "ChromePublicTest.[Render Tests] Upload Results",
+ "~followup_annotations": [
+ "@@@STEP_NEST_LEVEL@1@@@",
+ "@@@STEP_LOG_LINE@render results@<!DOCTYPE html><html></html>@@@",
+ "@@@STEP_LOG_END@render results@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"RECIPE_MODULE[build::chromium_android]/resources/test_results_presentation.py",
"--json-file",
"{\"per_iteration_data\": [{\"Test.One\": [{\"elapsed_time_ms\": 0, \"output_snippet\": \"\", \"status\": \"SUCCESS\"}], \"Test.Three\": [{\"elapsed_time_ms\": 0, \"output_snippet\": \"\", \"status\": \"SUCCESS\"}], \"Test.Two\": [{\"elapsed_time_ms\": 0, \"output_snippet\": \"\", \"status\": \"FAILURE\"}]}]}",
@@ -629,10 +668,10 @@
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
},
- "name": "ChromePublicTest: generate result details",
+ "name": "ChromePublicTest.ChromePublicTest: generate result details",
"stdout": "/path/to/tmp/",
"~followup_annotations": [
- "@@@STEP_TEXT@<br/>failures:<br/>Test.Two<br/>@@@",
+ "@@@STEP_NEST_LEVEL@1@@@",
"@@@STEP_LOG_LINE@result_details@<!DOCTYPE html><html></html>@@@",
"@@@STEP_LOG_END@result_details@@@"
]
@@ -661,7 +700,10 @@
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
},
- "name": "Upload to test-results [ChromePublicTest]"
+ "name": "ChromePublicTest.Upload to test-results [ChromePublicTest]",
+ "~followup_annotations": [
+ "@@@STEP_NEST_LEVEL@1@@@"
+ ]
},
{
"cmd": [

Powered by Google App Engine
This is Rietveld 408576698