Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.py

Issue 2439213002: Add step to process Render Test results. (Closed)
Patch Set: Addressed jbudorick's nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/example.py
diff --git a/scripts/slave/recipe_modules/chromium_android/example.py b/scripts/slave/recipe_modules/chromium_android/example.py
index e7c265993125e9d67265d2ba795749b98ad1d715..3c78f8f5c237247b1187f1add2524d27b9208899 100644
--- a/scripts/slave/recipe_modules/chromium_android/example.py
+++ b/scripts/slave/recipe_modules/chromium_android/example.py
@@ -90,7 +90,10 @@ BUILDERS = freeze({
'use_git_cache': False,
},
'json_results_file': {
- 'json_results_file': 'json_results_file'
+ 'json_results_file': 'json_results_file',
+ },
+ 'render_results': {
+ 'render_results_dir': 'chrome/test/data/android/render_tests',
},
'result_details': {
'result_details': True,
@@ -226,7 +229,8 @@ def RunSteps(api, buildername):
json_results_file=config.get('json_results_file'),
result_details=config.get('result_details'),
cs_base_url=config.get('cs_base_url'),
- store_tombstones=config.get('store_tombstones'))
+ store_tombstones=config.get('store_tombstones'),
+ render_results_dir=config.get('render_results_dir'))
ghost stip (do not use) 2016/12/08 20:16:02 ideally, we should detect the presence of these fi
mikecase (-- gone --) 2017/01/09 22:27:09 acknowledged. Going to keep it as is at first, so
api.chromium_android.run_test_suite(
'unittests',
isolate_file_path=api.path['checkout'].join('some_file.isolate'),

Powered by Google App Engine
This is Rietveld 408576698