Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8718)

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/find.js

Issue 2439203003: Reland of Accessibility: Ignore all anonymous blocks (Closed)
Patch Set: Rebased. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
index a686ded94d160632f761dc8967476f1392f0ecce..4f0d98efc795a847c86eb2ec0b257997edcbf614 100644
--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/find.js
@@ -9,7 +9,6 @@ var link;
var main;
var p2;
var p3;
-var anonGroup;
var okButton;
var cancelButton;
@@ -36,16 +35,13 @@ function initializeNodes(rootNode) {
p3 = main.lastChild;
assertEq(RoleType.paragraph, p3.role);
- anonGroup = rootNode.lastChild;
- assertEq(RoleType.group, anonGroup.role);
-
- okButton = anonGroup.firstChild;
+ okButton = rootNode.children[2];
assertEq(RoleType.button, okButton.role);
assertEq('Ok', okButton.name);
assertTrue(StateType.disabled in okButton.state);
assertTrue(okButton.state.disabled);
- cancelButton = anonGroup.lastChild;
+ cancelButton = rootNode.children[3];
assertEq(RoleType.button, cancelButton.role);
assertEq('Cancel', cancelButton.name);
assertFalse(StateType.disabled in cancelButton.state);
@@ -77,13 +73,6 @@ var allTests = [
assertEq(p2, main.find({ role: RoleType.paragraph }));
assertEq([p2, p3], main.findAll({ role: RoleType.paragraph }));
- // Unlike querySelector, can search from an anonymous group without
- // unexpected results.
- assertEq(okButton, anonGroup.find({ role: RoleType.button }));
- assertEq([okButton, cancelButton],
- anonGroup.findAll({ role: RoleType.button }));
- assertEq(null, anonGroup.find({ role: RoleType.heading }));
-
chrome.test.succeed();
},
@@ -101,12 +90,6 @@ var allTests = [
assertEq([okButton], rootNode.findAll({ role: RoleType.button,
state: { disabled: true }}));
- // Find disabled buttons within a portion of the tree.
- assertEq(okButton, anonGroup.find({ role: RoleType.button,
- state: { disabled: true }}));
- assertEq([okButton], anonGroup.findAll({ role: RoleType.button,
- state: { disabled: true }}));
-
// Find enabled buttons.
assertEq(cancelButton, rootNode.find({ role: RoleType.button,
state: { disabled: false }}));

Powered by Google App Engine
This is Rietveld 408576698