Script for exporting WPT

third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_wpt_unittest.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import unittest

[qyearsley, 2016/11/01 22:57:45]

Nit: Blank line separating import sections

[jeffcarp, 2016/11/03 23:54:07]

It seems like in the style guide that there's no blank line?
https://google.github.io/styleguide/pyguide.html?showone=Imports_formatting#I...

[qyearsley, 2016/11/04 17:40:32]

Yep, the blank line optional -- although most files in webkitpy usually have a
blank line between the general library imports and webkitpy imports.

+from webkitpy.w3c.chromium_wpt import ChromiumWPT
+from webkitpy.common.host_mock import MockHost

[qyearsley, 2016/11/01 22:57:45]

Nit: sort imports

+from webkitpy.common.system.executive_mock import MockExecutive2
+from webkitpy.common.system.filesystem_mock import MockFileSystem
+
+
+class ChromiumWPTTest(unittest.TestCase):
+
+    def test_has_changes_in_wpt(self):
+        host = MockHost()
+
+        def run_command_fn(_):
+            return """
+                something/something.html

[foolip, 2016/11/01 22:07:44]

I think the actual output wouldn't have a blank line at the start. You could
maybe add asserts to the implementation and not test it.

+                third_party/WebKit/LayoutTests/imported/wpt/something.html
+            """
+
+        host.executive = MockExecutive2(run_command_fn=run_command_fn)
+        host.filesystem = MockFileSystem()

[qyearsley, 2016/11/01 22:57:45]

No need to do this I think, since the constructor for MockHost sets filesystem
to be a new MockFileSystem by default.

+        local_wpt = ChromiumWPT(host)
+
+        self.assertTrue(local_wpt.has_changes_in_wpt('sha'))
+
+    def test_has_changes_in_wpt_looks_at_start_of_string(self):
+        host = MockHost()
+
+        def run_command_fn(_):
+            return """
+                something/something.html
+                something/third_party/WebKit/LayoutTests/imported/wpt/something.html
+            """
+
+        host.executive = MockExecutive2(run_command_fn=run_command_fn)
+        host.filesystem = MockFileSystem()
+        local_wpt = ChromiumWPT(host)
+
+        self.assertFalse(local_wpt.has_changes_in_wpt('sha'))
+
+    def test_has_changes_in_wpt_does_not_count_expectation_files(self):
+        host = MockHost()
+
+        def run_command_fn(_):
+            return """
+                something/something.html
+                something/third_party/WebKit/LayoutTests/imported/wpt/something-expected.html

[foolip, 2016/11/01 22:07:44]

Drop the something prefix here to make sure you're testing the right thing? And
add an -expected.txt to make sure that's also ignored.

+            """
+
+        host.executive = MockExecutive2(run_command_fn=run_command_fn)
+        host.filesystem = MockFileSystem()
+        local_wpt = ChromiumWPT(host)
+
+        self.assertFalse(local_wpt.has_changes_in_wpt('sha'))