Merge to m55: Fixed line start offsets.

Merge to m55: Fixed line start offsets.

Now they indeed refer to the offset at the start of each line. This means that if e.g. the first text node starts a new line, the first offset returned should be 0. Further, the offset equivalent to the text's length should never be returned.
I chose to stick with line start offsets instead of line breaks because what exactly is a line break? The beginning of the line, the end of the previous line or the line break character in between two lines when it exists? And what happens if there is no line break character, i.e. a soft line break?
Line start offsets are less ambiguous.
TBR=nektar@chromium.org
BUG=652059
R=dmazzoni@chromium.org, dtseng@chromium.org
TESTED=automation browsertests, manually with ChromeVox on ChromeOS

Review-Url: https://chromiumcodereview.appspot.com/2437473003
Cr-Commit-Position: refs/heads/master@{#426636}
(cherry picked from commit 6be580cbb1b4947179978c1c0f2dd9c680a99863)

Committed: https://chromium.googlesource.com/chromium/src/+/b2130a303ca27915ac7abbbefe9f675c582852d2

[David Tseng, 2016-10-21 17:06:05]

Description was changed from

==========
Fixed line start offsets.

Now they indeed refer to the offset at the start of each line. This means that
if e.g. the first text node starts a new line, the first offset returned should
be 0. Further, the offset equivalent to the text's length should never be
returned.
I chose to stick with line start offsets instead of line breaks because what
exactly is a line break? The beginning of the line, the end of the previous line
or the line break character in between two lines when it exists? And what
happens if there is no line break character, i.e. a soft line break?
Line start offsets are less ambiguous.
BUG=652059
R=dmazzoni@chromium.org, dtseng@chromium.org
TESTED=automation browsertests, manually with ChromeVox on ChromeOS

Review-Url: https://chromiumcodereview.appspot.com/2437473003
Cr-Commit-Position: refs/heads/master@{#426636}
(cherry picked from commit 6be580cbb1b4947179978c1c0f2dd9c680a99863)
==========

to

==========
Merge to m55: Fixed line start offsets.

Now they indeed refer to the offset at the start of each line. This means that
if e.g. the first text node starts a new line, the first offset returned should
be 0. Further, the offset equivalent to the text's length should never be
returned.
I chose to stick with line start offsets instead of line breaks because what
exactly is a line break? The beginning of the line, the end of the previous line
or the line break character in between two lines when it exists? And what
happens if there is no line break character, i.e. a soft line break?
Line start offsets are less ambiguous.
TBR=nektar@chromium.org
BUG=652059
R=dmazzoni@chromium.org, dtseng@chromium.org
TESTED=automation browsertests, manually with ChromeVox on ChromeOS

Review-Url: https://chromiumcodereview.appspot.com/2437473003
Cr-Commit-Position: refs/heads/master@{#426636}
(cherry picked from commit 6be580cbb1b4947179978c1c0f2dd9c680a99863)
==========

[David Tseng, 2016-10-21 17:12:53]

Description was changed from

==========
Merge to m55: Fixed line start offsets.

Now they indeed refer to the offset at the start of each line. This means that
if e.g. the first text node starts a new line, the first offset returned should
be 0. Further, the offset equivalent to the text's length should never be
returned.
I chose to stick with line start offsets instead of line breaks because what
exactly is a line break? The beginning of the line, the end of the previous line
or the line break character in between two lines when it exists? And what
happens if there is no line break character, i.e. a soft line break?
Line start offsets are less ambiguous.
TBR=nektar@chromium.org
BUG=652059
R=dmazzoni@chromium.org, dtseng@chromium.org
TESTED=automation browsertests, manually with ChromeVox on ChromeOS

Review-Url: https://chromiumcodereview.appspot.com/2437473003
Cr-Commit-Position: refs/heads/master@{#426636}
(cherry picked from commit 6be580cbb1b4947179978c1c0f2dd9c680a99863)
==========

to

==========
Merge to m55: Fixed line start offsets.

Now they indeed refer to the offset at the start of each line. This means that
if e.g. the first text node starts a new line, the first offset returned should
be 0. Further, the offset equivalent to the text's length should never be
returned.
I chose to stick with line start offsets instead of line breaks because what
exactly is a line break? The beginning of the line, the end of the previous line
or the line break character in between two lines when it exists? And what
happens if there is no line break character, i.e. a soft line break?
Line start offsets are less ambiguous.
TBR=nektar@chromium.org
BUG=652059
R=dmazzoni@chromium.org, dtseng@chromium.org
TESTED=automation browsertests, manually with ChromeVox on ChromeOS

Review-Url: https://chromiumcodereview.appspot.com/2437473003
Cr-Commit-Position: refs/heads/master@{#426636}
(cherry picked from commit 6be580cbb1b4947179978c1c0f2dd9c680a99863)

Committed:
https://chromium.googlesource.com/chromium/src/+/b2130a303ca27915ac7abbbefe9f...
==========

[David Tseng, 2016-10-21 17:12:55]

Committed patchset #1 (id:1) manually as
b2130a303ca27915ac7abbbefe9f675c582852d2 (presubmit successful).