third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp - Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited (Closed)

Patch Set: Rename decorationLayer to decorationOutlineLayer Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h ('k') | third_party/WebKit/Source/platform/graphics/CompositingReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

index 237e22190512fdcba26b6735648e2a823dbed1d9..214d2bb0d620be6fe66e369c4ea27d7975af1657 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp

@@ -145,9 +145,10 @@ TEST_F(PaintLayerScrollableAreaTest,

// outline is drawn outside the padding box.

EXPECT_TRUE(canPaintBackgroundOntoScrollingContentsLayer("scroller14"));

- // #scroller15 cannot paint background into scrolling contents layer because

- // the outline is drawn inside the padding box.

- EXPECT_FALSE(canPaintBackgroundOntoScrollingContentsLayer("scroller15"));

+ // #scroller15 can paint background into scrolling contents layer because

+ // the outline is drawn into the decoration layer which will not be covered

+ // up.

+ EXPECT_TRUE(canPaintBackgroundOntoScrollingContentsLayer("scroller15"));

// #scroller16 cannot paint background into scrolling contents layer because

// the scroller has a clip which would not be respected by the scrolling