Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited (Closed)
Patch Set: Rename decorationLayer to decorationOutlineLayer Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 0ec8c4584000d27cb667b14415a2d1128bae592a..e07e5e6d36fb28266a6e6a20fe502e127f4852c7 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -112,12 +112,6 @@ bool LayoutBoxModelObject::usesCompositedScrolling() const {
}
bool LayoutBoxModelObject::hasLocalEquivalentBackground() const {
- int minBorderWidth = std::min(
- style()->borderTopWidth(),
- std::min(
- style()->borderLeftWidth(),
- std::min(style()->borderRightWidth(), style()->borderBottomWidth())));
- bool outlineOverlapsPaddingBox = style()->outlineOffset() < -minBorderWidth;
bool hasCustomScrollbars = false;
// TODO(flackr): Detect opaque custom scrollbars which would cover up a
// border-box background.
@@ -146,15 +140,6 @@ bool LayoutBoxModelObject::hasLocalEquivalentBackground() const {
if (layer->attachment() == LocalBackgroundAttachment)
continue;
- // If the outline draws inside the border, it intends to draw on top of the
- // scroller's background, however because it is painted into a layer behind
- // the scrolling contents layer we avoid auto promoting in this case to
- // avoid obscuring the outline.
- // TODO(flackr): Outlines should be drawn on top of the scrolling contents
- // layer so that they cannot be covered up by composited scrolling contents.
- if (outlineOverlapsPaddingBox)
- return false;
-
// Solid color layers with an effective background clip of the padding box
// can be treated as local.
if (!layer->image() && !layer->next() &&

Powered by Google App Engine
This is Rietveld 408576698