third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-negative-offset-outline.html - Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-negative-offset-outline.html

Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited (Closed)

Patch Set: Update decoration layer existing condition Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-with-negative-offset-outline-expected.png » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="resources/text-based-repaint.js"></script>	2 <script src="resources/text-based-repaint.js"></script>

3 <script>	3 <script>

4 function repaintTest() {	4 function repaintTest() {

5 scroller.style.background = 'green local';	5 scroller.style.outline = '1px solid green';

6 }	6 }

7 onload = runRepaintAndPixelTest;	7 onload = runRepaintAndPixelTest;

8 </script>	8 </script>

9 <style>	9 <style>

10 #scroller {	10 #scroller {

11 background: red local;

12 overflow: scroll;	11 overflow: scroll;

13 width: 200px;	12 width: 200px;

14 height: 200px;	13 height: 200px;

15 will-change: transform;	14 will-change: transform;

	15 outline: 1px solid blue;
	flackr 2016/10/25 21:26:30 nit: it may be good to start the outline red so th nit: it may be good to start the outline red so that if it fails to update it is obvious that it is the wrong color. yigu 2016/10/27 20:21:26 That makes more sense. Show quoted text On 2016/10/25 at 21:26:30, flackr wrote: > nit: it may be good to start the outline red so that if it fails to update it is obvious that it is the wrong color. That makes more sense.
	16 outline-offset: -4px;

16 }	17 }

17	18

18 .spacer {	19 .spacer {

19 height: 300px;	20 height: 300px;

20 }	21 }

21 </style>	22 </style>

22 <!-- #scroller has a locally attached background which will be painted into the	23 <!-- #scroller has a negative offset outline which should not be covered up by

23 scrolling contents layer. When the color changes it should repaint. -->	24 the scrollbar. When the color changes it should repaint. -->

24 <div id="scroller">	25 <div id="scroller">

25 <div class="spacer"></div>	26 <div class="spacer"></div>

26 </div>	27 </div>

OLD	NEW