third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html - Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html

Issue 2439113003: Fix the bug that negative outline-offset is covered up by composited (Closed)

Patch Set: Update the ref test to remove unnecessary components && typo fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/composited-scrolling-paint-phases-expected.txt ('k') | third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline-expected.html » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <script>

	2 onload = function() {

	3 document.getElementById('scroller').scrollTop = 200;
	flackr 2016/11/16 21:14:20 nit: Scrolling is unnecessary for testing this. nit: Scrolling is unnecessary for testing this. yigu 2016/11/17 15:53:15 Done. Show quoted text On 2016/11/16 21:14:20, flackr wrote: > nit: Scrolling is unnecessary for testing this. Done.
	4 }

	5 </script>

	6 <style>

	7 #scroller {

	8 background: local grey;
	flackr 2016/11/16 21:14:20 Thinking about this some more, if we were double p Thinking about this some more, if we were double painting the outline (which is the main reason to test a partially translucent outline) we may obscure that by having a background on the scroller. Can you remove this background? yigu 2016/11/17 15:53:15 Done. Show quoted text On 2016/11/16 21:14:20, flackr wrote: > Thinking about this some more, if we were double painting the outline (which is > the main reason to test a partially translucent outline) we may obscure that by > having a background on the scroller. Can you remove this background? Done.
	9 outline: 5px solid rgba(0, 255, 0, 0.5);

	10 outline-offset: -4px;

	11 overflow: scroll;

	12 width: 200px;

	13 height: 200px;

	14 box-sizing: border-box;

	15 will-change: transform;

	16 }

	17

	18 .spacer {

	19 height: 300px;

	20 }

	21 </style>

	22 <!-- #scroller outline should not be covered up by scrolling content background.

	23 It is achieved by painting the outline into the decoration layer which draws

	24 on top of all other layers. -->

	25 <div id="scroller">

	26 <div class="spacer"></div>

	27 </div>

	28

OLD	NEW