Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2439113002: Reland "Move Java CachedMetrics functionality to base/." (Closed)

Created:
4 years, 2 months ago by Alexei Svitkine (slow)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, zpeng+watch_chromium.org, dominickn+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, jfweitz+watch_chromium.org, pkotwicz+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Move Java CachedMetrics functionality to base/." This is a re-land of: https://codereview.chromium.org/2435813002/ The reland keeps a TimesHistogramSample class in LaunchMetrics since it's still referenced in internal code. Once this lands, the clank/ code can be updated and this class can be cleaned up. Original CL description: This is general-purpose functionality that allows recording UMA metrics before the C++ native library has been loaded and is useful to have outside of the Chrome layer. In particular, I will be using it from components/variations to record information about the first run variations seed fetch. No functional changes in this CL. BUG=632199 TBR=bauerb@chromium.org, thestig@chromium.org Committed: https://crrev.com/3f60731a10573f0885db298817d897b13d01890a Cr-Commit-Position: refs/heads/master@{#426853}

Patch Set 1 : Original CL #

Patch Set 2 : Keep TimesHistogramSample in LaunchMetrics. #

Patch Set 3 : Add missing CachedMetrics class - unchanged from original CL. #

Messages

Total messages: 20 (14 generated)
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-21 16:44:55 UTC) #4
Ted C
lgtm
4 years, 2 months ago (2016-10-21 16:58:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439113002/20001
4 years, 2 months ago (2016-10-21 17:02:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439113002/40001
4 years, 2 months ago (2016-10-21 17:10:07 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-21 18:40:59 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 19:08:35 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f60731a10573f0885db298817d897b13d01890a
Cr-Commit-Position: refs/heads/master@{#426853}

Powered by Google App Engine
This is Rietveld 408576698