Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 2439083003: Replace flaky test, wrangle with harness/infra
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
index 0defc93a6d4b45592bd2b383a1bfbd414b8ee363..06f9775502e6aea36bed3578db693c75086e7b9a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
@@ -294,17 +294,23 @@ class SingleTestRunner(object):
pid=driver_output.pid, has_repaint_overlay=has_repaint_overlay)
def _compare_testharness_test(self, driver_output, expected_driver_output):
- if expected_driver_output.image or expected_driver_output.audio or expected_driver_output.text:
- return False, []
+ print "yoohoo"
+ print "yoohoo"
+ print "yoohoo"
+ print "yoohoo"
+ # if expected_driver_output.image or expected_driver_output.audio or expected_driver_output.text:
+ # return False, []
- if driver_output.image or driver_output.audio or self._is_render_tree(driver_output.text):
- return False, []
+ # if driver_output.image or driver_output.audio or self._is_render_tree(driver_output.text):
+ # return False, []
text = driver_output.text or ''
if not testharness_results.is_testharness_output(text):
+ print "yoohoo1"
return False, []
if not testharness_results.is_testharness_output_passing(text):
+ print "yoohoo2"
return True, [test_failures.FailureTestHarnessAssertion()]
return True, []

Powered by Google App Engine
This is Rietveld 408576698