Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: components/test_runner/test_runner.cc

Issue 2439083003: Replace flaky test, wrangle with harness/infra
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_runner.h ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 89ea49bdc4b4ee5a320ea9194c2afbc03d73736d..0906f0f374e4722b419e30271ca31f564efe19ab 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -137,6 +137,7 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void DumpAsMarkup();
void DumpAsText();
void DumpAsTextWithPixelResults();
+ void DumpPixelResults();
void DumpBackForwardList();
void DumpChildFrameScrollPositions();
void DumpChildFramesAsMarkup();
@@ -381,6 +382,7 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
.SetMethod("dumpAsText", &TestRunnerBindings::DumpAsText)
.SetMethod("dumpAsTextWithPixelResults",
&TestRunnerBindings::DumpAsTextWithPixelResults)
+ .SetMethod("dumpPixelResults", &TestRunnerBindings::DumpPixelResults)
.SetMethod("dumpBackForwardList",
&TestRunnerBindings::DumpBackForwardList)
.SetMethod("dumpChildFrameScrollPositions",
@@ -1079,6 +1081,11 @@ void TestRunnerBindings::DumpAsTextWithPixelResults() {
runner_->DumpAsTextWithPixelResults();
}
+void TestRunnerBindings::DumpPixelResults() {
+ if (runner_)
+ runner_->DumpPixelResults();
+}
+
void TestRunnerBindings::DumpChildFrameScrollPositions() {
if (runner_)
runner_->DumpChildFrameScrollPositions();
@@ -2440,6 +2447,11 @@ void TestRunner::DumpAsTextWithPixelResults() {
OnLayoutTestRuntimeFlagsChanged();
}
+void TestRunner::DumpPixelResults() {
+ layout_test_runtime_flags_.set_generate_pixel_results(true);
+ OnLayoutTestRuntimeFlagsChanged();
+}
+
void TestRunner::DumpChildFrameScrollPositions() {
layout_test_runtime_flags_.set_dump_child_frame_scroll_positions(true);
OnLayoutTestRuntimeFlagsChanged();
« no previous file with comments | « components/test_runner/test_runner.h ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698