Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2439083002: Do not run DualControlLayoutTest#testAlignSideBySide on JB (Closed)

Created:
4 years, 2 months ago by kraush
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not run DualControlLayoutTest#testAlignSideBySide on JB Every method in DualControlLayoutTest is already tagged with TargetAPI JellyBean MR1. This change disabled one of the tests accordingly to not run on any devices prior to JellyBean MR 1. The other DualControlLayoutTest works fine. BUG=658263 Committed: https://crrev.com/c441eed3a5dd0b720a993038179f01b119d3aee0 Cr-Commit-Position: refs/heads/master@{#430334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/DualControlLayoutTest.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kraush
Hi Miguel, Can you take a look at this change to disable a test on ...
4 years, 2 months ago (2016-10-21 15:04:02 UTC) #2
kraush
No response from Miguel yet :( Also tried reaching out via email to no avail. ...
4 years, 1 month ago (2016-10-31 15:23:49 UTC) #4
David Trainor- moved to gerrit
lgtm
4 years, 1 month ago (2016-11-07 18:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439083002/1
4 years, 1 month ago (2016-11-07 18:23:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:01:15 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:15:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c441eed3a5dd0b720a993038179f01b119d3aee0
Cr-Commit-Position: refs/heads/master@{#430334}

Powered by Google App Engine
This is Rietveld 408576698