DrawingBuffer: Add checks for state restorer

DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265
Committed: https://crrev.com/8dbf40b1f26fa7e9b0fae8ddec2b06d995d05d52
Cr-Commit-Position: refs/heads/master@{#427197}

[ccameron, 2016-10-21 16:38:27]

Description was changed from

==========
DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265
==========

to

==========
DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265
==========

[ccameron, 2016-10-21 16:38:27]

ccameron@chromium.org changed reviewers:
+ kbr@chromium.org

[ccameron, 2016-10-21 16:38:57]

At a loss to understand how this is happening, so adding checks to move the
crash to somewhere that might make more sense.

[Ken Russell (switch to Gerrit), 2016-10-22 01:36:31]

Is this reproducible with the test case from the fuzzer? It would be better to
debug this directly.

LGTM but please watch the crash rates on Canary with this change.

[ccameron, 2016-10-24 21:04:00]

Thanks!

On 2016/10/22 01:36:31, Ken Russell wrote:
> Is this reproducible with the test case from the fuzzer? It would be better to
> debug this directly.
> 
> LGTM but please watch the crash rates on Canary with this change.

I haven't managed to reproduce this locally -- I'll be watching Canary carefully
on this.

[ccameron, 2016-10-24 21:04:04]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:04:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:55:30]

Description was changed from

==========
DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265
==========

to

==========
DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265
==========

[commit-bot: I haz the power, 2016-10-25 00:55:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 00:58:52]

Description was changed from

==========
DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265
==========

to

==========
DrawingBuffer: Add checks for state restorer

We're crashing due to a null m_stateRestorer in the fuzzer. It's unclear
how this is possible, so add CHECKs to indicate where this is going
wrong.

These CHECKS should be changed to DCHECKs when the issue is addressed.

BUG=658265

Committed: https://crrev.com/8dbf40b1f26fa7e9b0fae8ddec2b06d995d05d52
Cr-Commit-Position: refs/heads/master@{#427197}
==========

[commit-bot: I haz the power, 2016-10-25 00:58:53]

Patchset 1 (id:??) landed as
https://crrev.com/8dbf40b1f26fa7e9b0fae8ddec2b06d995d05d52
Cr-Commit-Position: refs/heads/master@{#427197}